Use canonicalized URIs/paths for jump to definition #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhammerschmidt
force-pushed
the
use-canonicalized-uris
branch
from
41fbf07 to
af5df7a
Compare
zth
approved these changes
May 25, 2024
|
@fhammerschmidt just a rebase and we're ready to go. |
fhammerschmidt
force-pushed
the
use-canonicalized-uris
branch
from
af5df7a to
5aa7126
Compare
|
rebased and added a changelog now! |
jfrolich
pushed a commit
to jfrolich/rescript-vscode
that referenced
this pull request
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue when you have an internal package in a monorepo and you click on a module from it in another package, you end up at
node_modules/@yourNamespace/yourPackageName. Now it uses the real path and not the symlink anymore, so end up at the correct location.